add unit test for common/deliverclient/blocksprovider/delivery_requester #4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amrit Prakash <[email protected]>
solo-daemon
force-pushed
the
deliveryRequesterTest
branch
from
9756361
to
fef2b9c
Compare
Signed-off-by: Amrit Prakash <[email protected]>
|
@tock-ibm Could you review? |
tock-ibm
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
@solo-daemon
First of all thanks for this contribution!
This style of "fake mocks" based testing is good. The deliverer and bft_deliverer are tested this way. I will accept all the tests written here.
However, the issue calls for a more explicit style of testing - against a real gRPC service (a mockup for testing, not a real orderer).
See for example how it's done here: orderer/common/cluster/deliver_test.go where there is a deliverServer that implements the "Deliver" API. You can copy the deliverServer from there, and run the DeliveryRequester against it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #4567
Added unit test for deliveryRequester.